[crop] Clamp cursor within video dimensions, display crop zone DAR #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexeonify
added a commit
to dexeonify/mpv-config
that referenced
this pull request
Apr 30, 2023
- Clamp cursor within video dimensions - Display crop zone DAR
dexeonify
added a commit
to dexeonify/mpv-config
that referenced
this pull request
Sep 24, 2023
A continuation of 000fbe8 as occivink/mpv-scripts#67 was updated.
stanleyqubit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the script would allow for the drawing of the crop zone to begin even if the crop cursor was placed outside video dimensions (e.g. the area into which the video is rendered). This would show inaccurate crop zone dimensions when drawing the text for the crop zone.
This PR limits placing of the crop cursor within video dimensions area, and also adds a little quality-of-life feature that displays the aspect ratio of the crop zone before validation.